Fix rendering of code blocks in JupyterLab 4.3.0+ #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
commented
Nov 12, 2024
dlqqq
force-pushed
the
fix-jl430-rendering
branch
from
c9f9323
to
30454da
Compare
dlqqq
changed the title
jupyterlab>=4.3.0
dlqqq
changed the title
srdas
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Code is good.
- Upgraded JupyterLab in your environment to v4.3.0, the bug appears using the old code.
- Using the new branch, rebuilt the code.
- Restarted JupyterLab and verified that the bug is fixed.
- Downgraded to jupyterlab 4.2 and the bug is fixed.
- Upgraded back to jupyter lab 4.3 and the bug remains fixed.
All looks good now.
Downgrade JupyterLab to v4.2.0 by running conda install jupyterlab==4.2.0.
Restart JupyterLab, and verify that the bug is still fixed. This asserts that the changes don't break rendering for JupyterLab <4.3.0.
|
TY everybody! Merging. |
|
@meeseeksdev please backport to v3-dev |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Nov 12, 2024
dlqqq
added a commit
that referenced
this pull request
Nov 13, 2024
…1105) Co-authored-by: david qiu <david@qiu.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1090. For additional context, please review the thread there.
Testing instructions
mainbranch, upgrade JupyterLab in your environment to v4.3.0 by runningconda update jupyterlab.jlpm && jlpm build.conda install jupyterlab==4.2.0.Demo