-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix specifying empty list in provider and model allow/denylists #1185
Fix specifying empty list in provider and model allow/denylists #1185
Conversation
Related to Issue #913 |
To clarify, #913 documents a known issue where a user cannot specify a list containing a single item for a list configurable via However, specifying
The code looks good to me. I'll approve and start the CI. @srdas You can help verify this PR if you have extra time. |
|
@srdas Thank you for verifying! Looks like the unit tests failed, so I've updated them to pass and assert this PR's new changes. |
@meeseeksdev please backport to 2.x |
…d model allow/denylists
When setting
c.AiExtension.allowed_providers = []
, it acts like the default valueNone
and will show all models.We actually meant to not show any models at all. This is useful for when dynamically selecting models based on user/deployment.