Run Python unit tests as a part of CI #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-i
added
enhancement
|
forbid_write_write_conflict test fails in CI, passes locally |
|
It fails locally for me on Ubuntu as well when running all tests, but passes when running this test alone. Edit: To be more precise, it randomly passes or fails when run in isolation. |
andrii-i
force-pushed
the
run-unit-tests
branch
from
1a7940d
to
b982e5e
Compare
|
Thank you @krassowski. Marked the test to be skipped, added TODO comment to make the test work. |
andrii-i
force-pushed
the
run-unit-tests
branch
from
b982e5e
to
9cabe69
Compare
for more information, see https://pre-commit.ci
dlqqq
requested changes
Dec 18, 2023
dlqqq
approved these changes
Dec 18, 2023
|
Thanks @dlqqq and @krassowski for looking into this. |
andrii-i
changed the title
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Dec 18, 2023
andrii-i
added a commit
that referenced
this pull request
Dec 18, 2023
Co-authored-by: Andrii Ieroshenko <aieroshe@amazon.com>
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
* Add ci step to run unit tests * Skip test_forbid_write_write_conflict as flakey * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Comments per @dlqqq --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* Add ci step to run unit tests * Skip test_forbid_write_write_conflict as flakey * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Comments per @dlqqq --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unit tests are not ran as a part of CI.
Solution
This PR adds a "Unit Tests / Linux" CI step. Fixes #370.
forbid_write_write_conflict test fails in CI and is flakey on linux so this PR marks the test to be skipped, adds a TODO comment to make the test work.