-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds multi-environment variable authentication, Baidu Qianfan ERNIE-bot provider #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonWeill
changed the title
Multi env auth
Adds multi-environment variable authentication, Baidu Qianfan ERNIE-bot provider
Dec 20, 2023
Good news, Thank you @JasonWeill |
dlqqq
requested changes
Dec 20, 2023
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
JasonWeill
force-pushed
the
multi-env-auth
branch
from
December 21, 2023 01:18
f9564c1
to
dd1a9ac
Compare
@markqiu @JasonWeill Awesome work you two! This will go into the next minor release of Jupyter AI (v2.8.0). |
dlqqq
approved these changes
Dec 21, 2023
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Dec 21, 2023
…ation, Baidu Qianfan ERNIE-bot provider
dlqqq
pushed a commit
that referenced
this pull request
Dec 21, 2023
…du Qianfan ERNIE-bot provider (#539) Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
…ot provider (jupyterlab#531) * support baidu's qianfan ERNIE-Bot and ERNIE-Bot-4 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * support baidu's qianfan ERNIE-Bot and ERNIE-Bot-4 * Reinstates previous copies of example workbooks * Supports multiauth in magics, chat * Properly checks and reports on multiple env vars * Updates docs * Uses friendly name * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Refactoring, constants for strings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: qiuch <qiucheng@jinniuai.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
…ot provider (jupyterlab#531) * support baidu's qianfan ERNIE-Bot and ERNIE-Bot-4 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * support baidu's qianfan ERNIE-Bot and ERNIE-Bot-4 * Reinstates previous copies of example workbooks * Supports multiauth in magics, chat * Properly checks and reports on multiple env vars * Updates docs * Uses friendly name * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Refactoring, constants for strings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: qiuch <qiucheng@jinniuai.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #525, supersedes #478 by @markqiu. Thank you, @markqiu, for your contribution! I'd love your feedback on this change.
Supports multi-environment-variable authentication in the chat UI. Correctly detects multiple environment variables in the magic commands and chat UI, and checks that all variables are set correctly. The new
qianfan
(Baidu) provider is added; it requires two environment variables. Updates the documentation. Additional cleanup courtesy @markqiu.