Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes deprecated models, adds updated models for openai #596

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Removes deprecated models, adds updated models for openai #596

merged 2 commits into from
Jan 23, 2024

Conversation

JasonWeill
Copy link
Collaborator

@JasonWeill JasonWeill commented Jan 22, 2024 •
edited
Loading

Fixes #590. Removes currently deprecated OpenAI models, adds comments for OpenAI models which will soon be deprecated, adds new OpenAI models, and updates the sample notebook to avoid using deprecated models.

Tested all newly added models.

@JasonWeill JasonWeill added bug Something isn't working @jupyter-ai/magics and removed @jupyter-ai/magics labels Jan 22, 2024
krassowski
krassowski approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cross-checked against https://platform.openai.com/docs/models and it looks good to me, thank you!

@JasonWeill JasonWeill merged commit 71227d9 into jupyterlab:main Jan 23, 2024
11 checks passed
@JasonWeill
Copy link
Collaborator Author

@meeseeksdev please backport to 1.x

@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Jan 23, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 71227d9bb32ab91cdc5addfa3f01059567139797
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #596: Removes deprecated models, adds updated models for openai'
  1. Push to a named branch:
git push YOURFORK 1.x:auto-backport-of-pr-596-on-1.x
  1. Create a PR against branch 1.x, I would have named this PR:

"Backport PR #596 on branch 1.x (Removes deprecated models, adds updated models for openai)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@JasonWeill
Copy link
Collaborator Author

@meeseeksdev please backport to 1.x

@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Jan 23, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 71227d9bb32ab91cdc5addfa3f01059567139797
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #596: Removes deprecated models, adds updated models for openai'
  1. Push to a named branch:
git push YOURFORK 1.x:auto-backport-of-pr-596-on-1.x
  1. Create a PR against branch 1.x, I would have named this PR:

"Backport PR #596 on branch 1.x (Removes deprecated models, adds updated models for openai)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

JasonWeill added a commit to JasonWeill/jupyter-ai that referenced this pull request Jan 23, 2024
@JasonWeill
Removes deprecated models, adds updated models for openai (jupyterlab…
f4aa173 
…#596)

* Removes deprecated models, adds updated models for openai

* ASCIIbetical sort

(cherry picked from commit 71227d9)
@JasonWeill JasonWeill mentioned this pull request Jan 23, 2024
Merged
JasonWeill added a commit that referenced this pull request Jan 23, 2024
@JasonWeill
Backport PR #596 on branch 1.x (Removes deprecated models, adds updat…
660231b 
…ed models for openai) (#598)

* Base chat handler refactor for custom slash commands (#398)

* Adds attributes, starts adding to subclasses

* Consistent syntax

* Help for all handlers

* Fix slash ID error

* Iterate through entry points

* Fix typo in call to select()

* Moves config to magics, modifies extensions to attempt to load classes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Moves config to proper location, improves error logging

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* WIP: Updates per feedback, adds custom handler

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Removes redundant code, style fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Removes unnecessary custom message

* Instantiates class

* Validates slash ID

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Consistent arguments to chat handlers

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Refactors to avoid intentionally unused params

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updates docs, removes custom handler from source and config

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Renames process_message to match base class

* Adds needed parameter that had been deleted

* Joins lines in contributor doc

* Removes natural language routing type, which is not yet used

* Update docs/source/developers/index.md

Co-authored-by: Piyush Jain <piyushjain@duck.com>

* Update docs/source/developers/index.md

Co-authored-by: Piyush Jain <piyushjain@duck.com>

* Update docs/source/developers/index.md

Co-authored-by: Piyush Jain <piyushjain@duck.com>

* Revises per @3coins, avoids Latinism

* Removes Configurable, since we do not yet have configurable traits

* Uses Literal for validation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Piyush Jain <piyushjain@duck.com>
(cherry picked from commit 64e6daf)

* Removes redundant pydantic import

* Removes deprecated models, adds updated models for openai (#596)

* Removes deprecated models, adds updated models for openai

* ASCIIbetical sort

(cherry picked from commit 71227d9)
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@JasonWeill
Removes deprecated models, adds updated models for openai (jupyterlab…
0745a61 
…#596)

* Removes deprecated models, adds updated models for openai

* ASCIIbetical sort
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
@JasonWeill @Marchlak
Removes deprecated models, adds updated models for openai (jupyterlab…
bab5aa9 
…#596)

* Removes deprecated models, adds updated models for openai

* ASCIIbetical sort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

@krassowski krassowski krassowski approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we remove defunct OpenAI models?
3 participants
@JasonWeill @krassowski @dlqqq