Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add root package as Nx project #8

Merged
merged 2 commits into from
Mar 4, 2023
Merged

Add root package as Nx project #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
957a0d8
add package root to workspaces
dlqqq Mar 4, 2023
5624fc1
configure Nx to not include root scripts as Nx targets
dlqqq Mar 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "0.0.1",
"private": true,
"workspaces": [
".",
"packages/*"
],
"scripts": {
Expand All @@ -19,5 +20,8 @@
"devDependencies": {
"lerna": "^6.4.1",
"@jupyterlab/builder": "^3.1.0"
},
"nx": {
"includedScripts": []
}
Comment on lines +24 to 26
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration that tells Nx to not include root package scripts as Nx targets is required to stop root package scripts from causing an infinite loop. For example, yarn build on root calls lerna run build, which calls yarn build on root, etc. Now, lerna run build does not run on the root project because no targets are defined for that project.

}