Fix removal of pending messages on error #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
force-pushed
the
remove-pending-on-error
branch
2 times, most recently
from
cc18864
to
5a3e951
Compare
Closed
krassowski
force-pushed
the
remove-pending-on-error
branch
from
5a3e951
to
d99d52e
Compare
dlqqq
requested changes
Jul 12, 2024
There was a problem hiding this comment.
@krassowski Thank you for this bug fix! Really appreciate you going the extra mile here by adding unit tests too. Just one minor callout below. 👍
krassowski
force-pushed
the
remove-pending-on-error
branch
from
d99d52e
to
6b664c2
Compare
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* Add a test case for closing pending messages * Remove pending message on error * Add a test for not sending closing message twice * Review: make `close_pending` idempotent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #884