-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework selection replacement #895
Conversation
@dlq It all looks good. I get either a selection replaced or the entire text replaced. Nit: The replacement does not always take care of the highlighted text but all the lines. See the video below. I highlighted two lines of code by taking my cursor to the start of the third line, and it then replaces the third line also, even though it is not highlighted. See this video: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit -- all else looks good. If this is intended, please override the comment.
* remove replace selection checkbox * add useCopy() hook * fixup * add useReplace() hook * add menu for replacement & insertion options on agent messages * show 'replace 1 line' instead of 'replace 1 lines'
Description
Demo
Screen.Recording.2024-07-12.at.1.58.26.PM.mov