Migrate to langchain-aws for AWS providers
#909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
force-pushed
the
move-to-langchain-aws
branch
from
6ffa205
to
a477538
Compare
3coins
reviewed
Jul 24, 2024
JasonWeill
reviewed
Jul 24, 2024
packages/jupyter-ai-magics/jupyter_ai_magics/partner_providers/aws.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
3coins
reviewed
Jul 25, 2024
packages/jupyter-ai-magics/jupyter_ai_magics/partner_providers/aws.py
Outdated
Show resolved
Hide resolved
3coins
reviewed
Jul 25, 2024
packages/jupyter-ai-magics/jupyter_ai_magics/partner_providers/aws.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Piyush Jain <piyushjain@duck.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
srdas
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Reviewed the code, tested examples for chat, learn, ask, export, using different LLMs such as Claude and Mistral, which are moved to aws.py.
One small non-blocking (non-regressive) issue relating to the SmEndpointProvider class. Tried it with Llama3.1 and it works in the magics,
But throws an error in the chat invocation.
This may be related to the new Llama3.1 models and to be further explored.
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* migrate to langchain-aws * pre-commit * update aws provider dependencies in docs * correct SM endpoints docs URL Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * add new Cohere model IDs to BedrockEmbeddings Co-authored-by: Piyush Jain <piyushjain@duck.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * use BedrockLLM instead of Bedrock class * add Amazon, Meta, Mistral models to BedrockChatProvider * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> Co-authored-by: Piyush Jain <piyushjain@duck.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
langchain-awspackage.Demo
Screen.Recording.2024-07-24.at.3.39.54.PM.mov