Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving chat settings #935

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fix saving chat settings #935

merged 2 commits into from
Aug 6, 2024

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Aug 6, 2024

Description

Demo

Screen.Recording.2024-08-05.at.5.13.27.PM.mov

Demo of settings UI with empty config

Screen.Recording.2024-08-05.at.5.15.19.PM.mov

@dlqqq dlqqq added the bug Something isn't working label Aug 6, 2024
Copy link
Collaborator

@srdas srdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the new branch and it is all working as expected.
image
All code changes look good.
Thanks @dlqqq for a good fix!

@dlqqq dlqqq merged commit 7531f42 into jupyterlab:main Aug 6, 2024
10 checks passed
@dlqqq dlqqq deleted the fix-settings branch August 6, 2024 18:09
srdas added a commit that referenced this pull request Aug 10, 2024
* Bedrock usage documentation

Added a new section to user documentation for the use of Amazon Bedrock models, both base models and customized models.

* Bedrock docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix saving chat settings (#935)

* fix settings save

* show placeholder message when API keys section is empty

* Bedrock usage documentation

Added a new section to user documentation for the use of Amazon Bedrock models, both base models and customized models.

* Bedrock docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Subpage for Bedrock use

Added a link in the section on Amazon  Bedrock Usage in the docs to a subpage titled `Using Amazon Bedrock with Jupyter AI` which offers a detailed workflow for using Bedrock models, fine tuning them, and calling them in Jupyter AI.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updates to user docs

Addresses comment by Jason Weill

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: david qiu <david@qiu.dev>
michaelchia pushed a commit to michaelchia/jupyter-ai that referenced this pull request Aug 12, 2024
* Bedrock usage documentation

Added a new section to user documentation for the use of Amazon Bedrock models, both base models and customized models.

* Bedrock docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix saving chat settings (jupyterlab#935)

* fix settings save

* show placeholder message when API keys section is empty

* Bedrock usage documentation

Added a new section to user documentation for the use of Amazon Bedrock models, both base models and customized models.

* Bedrock docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Subpage for Bedrock use

Added a link in the section on Amazon  Bedrock Usage in the docs to a subpage titled `Using Amazon Bedrock with Jupyter AI` which offers a detailed workflow for using Bedrock models, fine tuning them, and calling them in Jupyter AI.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updates to user docs

Addresses comment by Jason Weill

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: david qiu <david@qiu.dev>
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
* fix settings save

* show placeholder message when API keys section is empty
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
* Bedrock usage documentation

Added a new section to user documentation for the use of Amazon Bedrock models, both base models and customized models.

* Bedrock docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix saving chat settings (jupyterlab#935)

* fix settings save

* show placeholder message when API keys section is empty

* Bedrock usage documentation

Added a new section to user documentation for the use of Amazon Bedrock models, both base models and customized models.

* Bedrock docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Subpage for Bedrock use

Added a link in the section on Amazon  Bedrock Usage in the docs to a subpage titled `Using Amazon Bedrock with Jupyter AI` which offers a detailed workflow for using Bedrock models, fine tuning them, and calling them in Jupyter AI.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updates to user docs

Addresses comment by Jason Weill

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: david qiu <david@qiu.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot save via chat settings
2 participants