Ray based document parsing of more file types #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellisonbg
changed the title
|
@ellisonbg |
ellisonbg
changed the title
|
OK, this is ready for review. |
JasonWeill
reviewed
Apr 19, 2023
JasonWeill
reviewed
Apr 19, 2023
| loader_kwargs: Optional[Dict] = None, | ||
| recursive: bool = False, | ||
| path, | ||
| extensions={'.py', '.md', '.R', '.Rmd', '.jl', '.sh', '.ipynb', '.js', '.ts'}, |
There was a problem hiding this comment.
Should we add .tsx and .txt here?
There was a problem hiding this comment.
Yeah, and .jsx as well.
| recursive: bool = False, | ||
| path, | ||
| extensions={'.py', '.md', '.R', '.Rmd', '.jl', '.sh', '.ipynb', '.js', '.ts'}, | ||
| exclude={'.ipynb_checkpoints', 'node_modules', 'lib', 'build'} |
There was a problem hiding this comment.
Might be good to ignore .git and .DS_Store as well
There was a problem hiding this comment.
Could we parse .gitignore and use that for our denylist by default? This can be addressed in a follow-up PR, since the problem of "over-indexing" is generally not immediately obvious to end users.
There was a problem hiding this comment.
Yep, let's explore this in a follow up PR.
Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
dlqqq
requested changes
Apr 19, 2023
| recursive: bool = False, | ||
| path, | ||
| extensions={'.py', '.md', '.R', '.Rmd', '.jl', '.sh', '.ipynb', '.js', '.ts'}, | ||
| exclude={'.ipynb_checkpoints', 'node_modules', 'lib', 'build'} |
There was a problem hiding this comment.
Could we parse .gitignore and use that for our denylist by default? This can be addressed in a follow-up PR, since the problem of "over-indexing" is generally not immediately obvious to end users.
dlqqq
previously requested changes
Apr 19, 2023
ellisonbg
dismissed
dlqqq’s stale review
All points addressed or will iterate in further PRs.
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
* Ray based document parsing of more file types. * Renaming to learn/ask to make for human centered. * Improvements to the learn/ask commands. * fix typo Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * improve grammar Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * improve wording Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * Adding new extensions and excludes. * Update langchain to version 0.144. --------- Co-authored-by: david qiu <david@qiu.dev> Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* Ray based document parsing of more file types. * Renaming to learn/ask to make for human centered. * Improvements to the learn/ask commands. * fix typo Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * improve grammar Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * improve wording Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com> * Adding new extensions and excludes. * Update langchain to version 0.144. --------- Co-authored-by: david qiu <david@qiu.dev> Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a general improvement to the file indexing capabilities: