Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Initialize and update the ydoc path property' #342 #357

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Sep 19, 2024

This PR is a backport of #342 to fix #341 on 2.x branch

Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupyter_collaboration/backport#342_

@brichet brichet added the bug Something isn't working label Sep 19, 2024
@brichet brichet changed the title Backport PR #342 to 2.x branch Backport 'Initialize and update the ydoc path property' #342 Sep 20, 2024
@davidbrochart
Copy link
Collaborator

@brichet did we forget to merge this one?

@brichet
Copy link
Contributor Author

brichet commented Oct 17, 2024

Probably, but I don't know why the test are failing...
I'll rebase and we'll see

@brichet
Copy link
Contributor Author

brichet commented Oct 21, 2024

Probably, but I don't know why the test are failing...

Actually these tests seem to fail with every PR on 2.x branch.

Co-authored-by: David Brochart <david.brochart@gmail.com>
@davidbrochart davidbrochart merged commit 9a71e85 into jupyterlab:2.x Oct 23, 2024
18 of 20 checks passed
@brichet brichet deleted the backport_#342 branch October 24, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants