Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to GitHub Actions on CI #242

Merged
merged 4 commits into from
Mar 3, 2021
Merged

Switch to GitHub Actions on CI #242

merged 4 commits into from
Mar 3, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 1, 2021

  • Switch from Travis to GitHub Actions on CI
  • Checks the extensions are correctly installed

@jtpio jtpio closed this Mar 1, 2021
@jtpio jtpio reopened this Mar 1, 2021
@jtpio
Copy link
Member Author

jtpio commented Mar 1, 2021

Example run in this fork: https://github.com/jtpio/jupyter-renderers/pull/1/checks?check_run_id=2004151471

@jtpio jtpio mentioned this pull request Mar 1, 2021
Merged
7 tasks
@jtpio jtpio changed the title Switch to GitHub Actions for CI Switch to GitHub Actions on CI Mar 2, 2021
@jtpio @jasongrout
Update .github/workflows/main.yml
2a68ab1 
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
jasongrout
jasongrout approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@jasongrout jasongrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtpio, your changes look great to me. If my last commit adding caching looks good to you, feel free to merge. Thanks!

@jtpio
Copy link
Member Author

jtpio commented Mar 3, 2021

Thanks Jason for the review and improvements!

Would be nice to get this in so it can be used in #243 too.

If my last commit adding caching looks good to you, feel free to merge.

Would be happy to do so, but it looks like I don't have commit rights on this repo.

@jasongrout
Copy link
Contributor

Would be happy to do so, but it looks like I don't have commit rights on this repo.

Fixed!

@jasongrout jasongrout merged commit 7305506 into jupyterlab:master Mar 3, 2021
@jtpio jtpio mentioned this pull request Mar 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasongrout jasongrout jasongrout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @jasongrout