Fix build on mybinder.org #147
Closed
+32
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Could we add a workflow with https://github.com/jupyterhub/repo2docker-action/?tab=readme-ov-file#optional-inputs and |
minrk
reviewed
Feb 3, 2025
| #- xtensor | ||
| #- xtensor-blas | ||
| #- xwidgets | ||
| - xleaflet |
There was a problem hiding this comment.
I think you need to lose xleaflet and xeus-python, too, not sure.
yuvipanda
added a commit
to yuvipanda/mybinder.org-deploy
that referenced
this pull request
Feb 8, 2025
Follow-up to jupyterhub#3204, which failed because it removed the limit, which caused it to be lower than the request. All the reasons given in that PR still apply. Here I bump up the limit enough until the super popular https://github.com/jupyterlab/jupyterlab-demo is able to build. It's not a functionally super complex environment.yml, and even with simplifications in jupyterlab/jupyterlab-demo#147, it fails to build without the memory increase limit. As mentioned in the other PR, jupyterhub/repo2docker#1402 will get rid of this kind of limit anyway, so it's ok to raise this.
|
Closing in favor of the simpler #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bunch of debugging, there were two primary issues:
I fixed (2) in jupyterhub/mybinder.org-deploy#3211, and (1) by temporarily commenting out xeus-cling in this repo. This would allow mybinder.org builds to resume, which I think makes it worthwhile. We should investigate why and fix this eventually though.
I also moved this to be based off a jupyter docker stacks base image, as I think that does make maintenance easier.
Reported in https://jupyter.zulipchat.com/#narrow/channel/469744-jupyterhub/topic/try.20mybinder.20jupyterleab.20demo.20broken