Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop QuantStack channel and only use conda-forge #81

Merged
merged 2 commits into from
Jun 2, 2019

Conversation

SylvainCorlay
Copy link
Member

Now possible since the rebuild.

@ian-r-rose
Copy link
Member

Thanks for the simplification @SylvainCorlay. This looks good, except that the appveyor failure looks legitimate (it couldn't find xeus-cling). Is it possible that it hadn't made its way through the feedstock yet, or is something wrong with the windows build?

I've kicked the CI in case it's the former.

@SylvainCorlay
Copy link
Member Author

@ian-r-rose cling and xeus-cling are not yet packaged for windows on conda-forge. It is probably not going to be in the very near future. The QuantStack channel builds exist but they are in fact not fully functional because cling 0.5 does not support windows.

@SylvainCorlay
Copy link
Member Author

I am currious why we check the environment with appveyor since binder is linux only?

@vidartf
Copy link
Member

vidartf commented Feb 13, 2019

It would be nice if the demo continues to work on Windows! I have a small demo I want to do this week, and I cannot rely on internet being present at the site.

@SylvainCorlay
Copy link
Member Author

The thing is that the cling interpreter is not really supported on windows, so whatever build was there is not really functional.

I would be nice to be able to specify that a requirement is only required on a certain platform...

@ian-r-rose ian-r-rose merged commit a26cf52 into jupyterlab:master Jun 2, 2019
@SylvainCorlay SylvainCorlay deleted the use-conda-forge branch June 2, 2019 22:24
@SylvainCorlay
Copy link
Member Author

Yeah! Thanks @ian-r-rose for pushing this forward.

@ian-r-rose
Copy link
Member

Sorry for the extremely slow merge on this @SylvainCorlay, and thanks for the updates! In the interests of getting the binder back up-and-running, we'll just move forwards here without Windows builds, and figure that out later.

@ian-r-rose
Copy link
Member

@SylvainCorlay I am currently seeing something broken with the xleaflet map in the C++ notebook -- does anything strike you as wrong with the current versions?

@SylvainCorlay
Copy link
Member Author

I am afk (replying from my phone). You may need to update ipyleaflet as well.

@SylvainCorlay
Copy link
Member Author

(Fornthe semver range check to pass, if this is the issue that you are seeing in the js console)

@ian-r-rose
Copy link
Member

Ah, yep, I see the semver error in the console, good call.

@ian-r-rose ian-r-rose mentioned this pull request Jul 10, 2019
@jtpio jtpio mentioned this pull request Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants