-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop QuantStack channel and only use conda-forge #81
Conversation
995c646
to
59ab109
Compare
Thanks for the simplification @SylvainCorlay. This looks good, except that the appveyor failure looks legitimate (it couldn't find I've kicked the CI in case it's the former. |
@ian-r-rose cling and xeus-cling are not yet packaged for windows on conda-forge. It is probably not going to be in the very near future. The QuantStack channel builds exist but they are in fact not fully functional because cling 0.5 does not support windows. |
I am currious why we check the environment with appveyor since binder is linux only? |
It would be nice if the demo continues to work on Windows! I have a small demo I want to do this week, and I cannot rely on internet being present at the site. |
The thing is that the cling interpreter is not really supported on windows, so whatever build was there is not really functional. I would be nice to be able to specify that a requirement is only required on a certain platform... |
abab55a
to
e94928a
Compare
Yeah! Thanks @ian-r-rose for pushing this forward. |
Sorry for the extremely slow merge on this @SylvainCorlay, and thanks for the updates! In the interests of getting the binder back up-and-running, we'll just move forwards here without Windows builds, and figure that out later. |
@SylvainCorlay I am currently seeing something broken with the xleaflet map in the C++ notebook -- does anything strike you as wrong with the current versions? |
I am afk (replying from my phone). You may need to update ipyleaflet as well. |
(Fornthe semver range check to pass, if this is the issue that you are seeing in the js console) |
Ah, yep, I see the semver error in the console, good call. |
Now possible since the rebuild.