Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GITHUB_API on client configurable #62

Open
ktong opened this issue Jul 18, 2018 · 3 comments
Open

Make GITHUB_API on client configurable #62

ktong opened this issue Jul 18, 2018 · 3 comments
Labels
enhancement status:Help Wanted

Comments

@ktong
Copy link
Contributor

ktong commented Jul 18, 2018

Our GHE can be connect directly from browser. So if GITHUB_API is configurable, then we do not need server side proxy.
@ian-r-rose
Copy link
Member

Do you connect with an access token? The primary reason for the server-side proxy is security: since the access token or client_secret are effectively passwords to a user's GitHub account, it is unsafe to store them client-side.

@ktong
Copy link
Contributor Author

ktong commented Jul 18, 2018 •
edited
Loading

It does not need access token as user already accesses GHE. Probably Cookie enables access of GHE. If not, access token in access URL also acceptable.

@ian-r-rose
Copy link
Member

I have no objection to this enhancement (so long as there is no security issue), but I can't really do it myself without good access to a GHE account. PRs welcome though, and I'm happy to help!

@dhirschfeld dhirschfeld mentioned this issue Sep 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement status:Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ktong @ian-r-rose