Many "Skipping this default shortcut because it collides with another default shortcut." warnings

[krassowski]

Description

Opening JupyterLab results in dozens of warnings like:

The shortcuts it complains about are:

• Accel Enter for notebook:run-cell added in Add additional Accel Enter keyboard shortcuts for the notebook:run-cell command #11942 CC @jtpio; I am not sure about this one, and would appreciate if you could look into this
• Shift Accel , for settingeditor:open-json added in Add settings UI #11079 CC @marthacryan - this conflicts with new settings UI which also has the same shortcut assigned and the same selector; we need to change it; up to discussion how.

It could be either:

• genuine mistake in the PRs mentioned above
• a regression in logic as a collateral of changes added in Add settings UI #11079.

I am not sure which it is. This warning and logic was added in #9858 (CC @jasongrout).

Note: we are currently working around this check in #12091.

Reproduce

1. Open 3.3.0rc0
2. Open developer console
3. See errors

Expected behavior

No warnings; all shortcuts get activated.

Context

• Browser and version: Chrome 98
• JupyterLab version: 3.3.0rc0 and master

[fcollonval]

For the settings editor shortcut, it seems appropriate to set the one on master:

   {
      "command": "settingeditor:open",
      "args": {},
      "keys": ["Accel ,"],
      "selector": "body"
    },
    {
      "command": "settingeditor:open-json",
      "args": {},
      "keys": ["Shift Accel ,"],
      "selector": "body"
    },

[fcollonval]

For the run cell commands, actually when defining multiple shortcuts they need to be defined in the same object (keys is a list of shortcuts).

Pushing a PR now.

[fcollonval]

Ok in fact the settingeditor:open-json is in conflict with

    {
      "command": "application:activate-previous-tab-bar",
      "keys": ["Ctrl Shift ,"],
      "selector": "body"
    },

from application-extension.

[fcollonval]

So I propose to drop it.