Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open a new view is broken #12965

Closed
fcollonval opened this issue Aug 18, 2022 · 0 comments · Fixed by #12701
Closed

open a new view is broken #12965

fcollonval opened this issue Aug 18, 2022 · 0 comments · Fixed by #12701
Labels
Milestone

Comments

@fcollonval
Copy link
Member

Description

#12349 breaks the clone view command because the opener is no more defined in the plugin adding the commands

Reproduce

  1. Open a notebook
  2. Right click on the notebook tab
  3. Select New view for notebook
  4. Nothing happen an error is emitted in the console

Expected behavior

No error
It seems the solution would be to provide the opener as a plugin to be requested by the plugin adding the commands.

Context

  • JupyterLab version: master
Troubleshoot Output
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Browser Output
Paste the output from your browser Javascript console here, if applicable.
@fcollonval fcollonval added bug status:Needs Triage Applied to new issues that need triage labels Aug 18, 2022
fcollonval added a commit that referenced this issue Aug 18, 2022
@fcollonval fcollonval linked a pull request Aug 18, 2022 that will close this issue
@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Aug 18, 2022
@fcollonval fcollonval added this to the 4.0.0 milestone Aug 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants