Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export createRendermimePlugin from @jupyterlab/application #10117

Merged
merged 2 commits into from
Apr 19, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 19, 2021

References

This is a proposal to export the following two utility functions:

  • createRendermimePlugin
  • createRendermimePlugins

from the @jupyterlab/application package.

This let other JupyterLab distributions be able to import them with:

import { createRendermimePlugin, createRendermimePlugins } from '@jupyterlab/application';

Instead of:

import { createRendermimePlugin, createRendermimePlugins } from '@jupyterlab/application/lib/mimerenderers';

Examples:

Code changes

Export two more functions from @jupyterlab/application.

User-facing changes

None

Backwards-incompatible changes

None.

This however brings two functions to the API surface.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 3.1 milestone Apr 19, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 2b02934 into jupyterlab:master Apr 19, 2021
@jtpio jtpio deleted the expose-createmimerenderplugins branch April 19, 2021 17:04
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance pkg:application status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants