Add Skip Link

[0618]

References

#9688

Code changes

• Add SkipLink Widget

User-facing changes

• Add SkipLink UI. When user tab through the page, the first think they focus is the SkipLink.
• Hit enter on the SkipLink "Skip to Filter Files", the focus moves to the "Filter Files Input".

Screen.Recording.2021-04-27.at.11.01.05.PM.mov

Backwards-incompatible changes

[jupyterlab-dev-mode]

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link:

[isabela-pf]

This looks done from my perspective! I think this is a good place to fulfill skiplink needs and for us to build off of in having a more robust set of skiplinks by region (as discussed in accessibility meetings) once we know this is working.

Wonderful work on and bravely diving into a new topic and asking thoughtful questions (while teaching us all more about skiplink in the process)!

[marthacryan]

Side note: JupyterLab uses a yarn.lock instead of a package-lock.json, could you remove that file from the PR?

[0618]

Side note: JupyterLab uses a yarn.lock instead of a package-lock.json, could you remove that file from the PR?

🤦 Removed.

[telamonian]

LGTM! From a basic coding and layout perspective, this looks good. I'd like to get confirmation from @manfromjupyter that this skip link does what it's supposed to do before we pull it in

[telamonian]

Suggested change

	'#filename-searcher .bp3-input'
	'#filename-searcher input'

.bp3-input is a styling class that may change in the future. Searching for just the input tag will make this less fragile

[telamonian]

Trying this PR out on binder, it seems like in fact it's currently not quite doing everything a skip link needs to be doing. We should discuss this more at the upcoming accessibility meeting.

[telamonian]

LGTM (for real this time)! I tested this out on my own machine. There are still some issues (eg pressing tab multiple times when a notebook is open will end up indenting the first cell of the notebook and never reach the skip link), but basic functionality is there and we can iterate and improve on this

[0618]

LGTM (for real this time)! I tested this out on my own machine. There are still some issues (eg pressing tab multiple times when a notebook is open will end up indenting the first cell of the notebook and never reach the skip link), but basic functionality is there and we can iterate and improve on this

Thanks!
Yea. I noticed that too today. I'll fix it next time.