Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of mathjax in notebook example #10134

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 22, 2021

References

Attempt to fix #10106

Code changes

Use the mathjax endpoint provided by nbclassic instead of the mathjax CDN

User-facing changes

N/A

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 3.1 milestone Apr 22, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 66af734 into jupyterlab:master Apr 22, 2021
@jtpio jtpio deleted the mathjax-example branch April 22, 2021 11:41
@blink1073 blink1073 added the bug label Jul 21, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky notebook example test?
2 participants