Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor apputils widgets #10758

Merged
merged 7 commits into from
Aug 6, 2021
Merged

Refactor apputils widgets #10758

merged 7 commits into from
Aug 6, 2021

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Aug 2, 2021 •
edited
Loading

References

To allow JupyterLab remix, this extracts some widgets from apputils to ui-components.

Code changes

The following widgets have been moved to ui-components:

  • Collapse
  • Spinner
  • IFrame
  • Toolbar
  • VDOM (ReactWidget, UseSignal, VDomModel, VDOMRenderer)

Collapse has been renamed to Collapser as ui-components has already a react component named Collapse.

Side effect, some tokens in apputils where not in the token.ts file. This corrects it.

User-facing changes

N/A

Backwards-incompatible changes

API preserved - but tagged as deprecated

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 4.0 milestone Aug 2, 2021
@fcollonval fcollonval marked this pull request as ready for review August 4, 2021 10:08
@fcollonval fcollonval added the api-change A change that should be accompanied by a major version increase label Aug 4, 2021
blink1073
blink1073 approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you!

@blink1073 blink1073 merged commit cb406d3 into jupyterlab:master Aug 6, 2021
@fcollonval fcollonval deleted the ft/refactor-components branch August 6, 2021 07:26
@karlaspuldaro karlaspuldaro mentioned this pull request Jan 5, 2022
Closed
@ajbozarth ajbozarth mentioned this pull request Jan 24, 2022
Closed
4 tasks
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees

@fcollonval fcollonval

Labels
api-change A change that should be accompanied by a major version increase Design System CSS documentation maintenance pkg:apputils pkg:cells pkg:codemirror pkg:csvviewer pkg:debugger pkg:docmanager pkg:docregistry pkg:documentsearch pkg:extensionmanager pkg:filebrowser pkg:fileeditor pkg:help pkg:htmlviewer pkg:launcher pkg:logconsole pkg:notebook pkg:property-inspector pkg:running pkg:settingeditor pkg:statusbar pkg:ui-components status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes tag:Examples
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @blink1073