Fix debugger UI tests #11998
Fix debugger UI tests #11998
Conversation
|
Thanks for making a pull request to jupyterlab! |
fcollonval
force-pushed
the
fix/debugger-ui-test
branch
from
188e83a to
bcc559e
Compare
|
@JohanMabille do you have any idea why the event initialized would not be emitted in ipykernel? |
|
Using |
|
These are the ipykernel PR merged between 6.7.0 and 6.8.0 ipython/ipykernel#816 and ipython/ipykernel#844 related to modules request (I have done them but don't see how it could impact) |
|
Commit b99e162 is testing the fix ipython/ipykernel#855 |
|
No idea why b99e162 does not work - it works locally. So waiting for a patch release on ipykernel |
|
It should work but I remember having weird behavior with explictit git revision number. You could try "git+https://github.com/ipython/ipykernel.git@master#egg=ipykernel" |
|
main, not master: git+https://github.com/ipython/ipykernel.git@main#egg=ipykernel |
|
Fixed by upstream ipykernel v6.9.0 release |
References
UI tests on master are failing due to the debugger panel not opening when the notebook debugger is opened.
The bug is related to ipykernel 6.8.0 (I succeed to reproduce it after upgrading from ipykernel 6.7.0 to 6.8.0). Still looking for the root cause.
The initialized event does not appear on the kernel comm.
Code changes
User-facing changes
Backwards-incompatible changes