Fixes toolbar button for Restart Kernel and Run All

[JasonWeill]

References

Fixes #11898.

Code changes

Falls back to default label/caption if all labels/captions of subcommands in a semanticCommand are empty strings

User-facing changes

Before the change, the ⏩ toolbar button had the caption " and " (with leading/trailing spaces):

After the change, the "Restart the kernel and run all cells" notebook toolbar button has an appropriate caption:

Other toolbar buttons also have captions in sentence case (only the first word is capitalized) with definite articles used ("Interrupt Kernel" becomes "Interrupt the kernel").

Backwards-incompatible changes

None.

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[krassowski]

Would you be able to add a unit test to

jupyterlab/packages/application/test/utils.spec.ts

Line 17 in 5a9896f

describe('createSemanticCommand', () => {

for this one, please?

[JasonWeill]

Upon further inspection, it looks like caption is always considered to be "" for the subcommands of a semanticCommand, even when I modified those commands to have a caption of their own. This seems to be the root cause of this issue.

(Edit: This is not correct; see comment below from Feb 8)

[JasonWeill]

please update galata snapshots

[JasonWeill]

This PR now fixes all toolbar buttons to have consistent casing by:

1. Declaring caption for all commands used in the notebook toolbar, with sentence casing and definite articles used. For example, if label is "Interrupt Kernel", caption is "Interrupt the kernel".
2. Using the notebook, not the runmenu, command for "Restart and run all". The semanticCommand logic would have capitalized the semantic command as "Restart the kernel and Run all cells" because each command starts with a capital letter. In the run menu, where the Title Case label is used, this is fine.

The semanticCommand logic is largely reverted in my changes today, although one change (to use label or caption for a single-command semanticCommand's label or caption) remains.

[fcollonval]

Thanks @JasonWeill

[krassowski]

Since this was merged I saw the icon was gone but instead the text was shown:

This was because I had customised my buttons in toolbar (well I did not, but when you go to Notebook Panel in settings it saves the default to user settings) and the old runmenu:restart-and-run-all remains for me rather than getting the now-default.

To fix this manually go into Settings → Notebook Panel → find item with runmenu:restart-and-run-all and replace it with notebook:restart-run-all.

I think that this will affect everyone who opened settings Settings → Notebook Panel in earlier version as this wrongly triggers an update.

I am not sure if want to take any action here, just flagging this.

[JasonWeill]

@krassowski I also saw this and I didn't realize that this was the cause. Is there something that I can do to automate this process on upgrade?

[krassowski]

I guess we could consider shipping a migration script, but I think we don't attach application version to the settings which will makes it non trivial. Let's continue the discussion in #13972