Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
400% Zoom screen usability enhancements - Updated #14766
400% Zoom screen usability enhancements - Updated #14766
Changes from 7 commits
dc6ddf2
8e7c0cf
ef536e9
5c2d84d
9ec2efd
d642591
bae2aa4
0548f95
469905b
ac6c403
e2253b4
b51bf2e
f27a147
a59c52f
62d76b3
1227434
95a7285
f97fc01
0e0d22a
321694a
e912df6
07053f1
bf09e1e
8df2d75
39ffb50
1cbb71a
aa06963
5df2df4
efd6180
c475e73
d8265f9
c3a0e88
5c648b8
f8a2c1d
44d9ea7
e410bda
e2dcab0
45c545f
745dd05
9044dd6
7ed43d8
dca42a0
22122ff
3de71be
2f4715a
f4e6a1a
34446f7
df6a6ab
d2a898b
75e0c8a
8f121a2
b04b7f9
a1a362f
0117fcc
7a42213
b8495a7
0bf18bf
e23f08e
8d89626
2aff43d
e7ebbb1
240eb80
28398f0
adf5b3f
9fb91fb
e8758be
2ca51c7
4af5f58
40015a1
1eafa89
dd92b8f
f1e5766
fb85ccc
f765428
0794c74
ff2bdc6
3ef7748
38032f5
e1a2f0a
a3a1d92
a121aaa
84f611b
0de7032
f48fea0
ea4a304
00a407c
df01261
7ec2d04
472daeb
6774e82
c8ef84c
9a1bb67
1afe2be
41f02d5
bce16fe
30b01dd
7335fb3
47c02ab
2469b2d
2bb414d
8088313
23b0347
5cc4041
7dbbff6
89b63ff
0e8487c
64a6371
53e2283
afe4981
643f52b
9ce275e
f621d4d
f2d6d24
04d5df9
cb8079b
e51cebf
ab5c98d
22847a6
95ab8e9
90f0de6
baa39e4
e5ce1cd
de84349
23e41c3
c2fa25e
1fc2656
585ac23
155d3f8
c3a6612
e19bf11
7cb79a5
e5bcdc8
a65f2ac
60da49e
62d823f
5485c8b
6dbbf3e
f004103
ac3bf28
4a2073f
54871f9
fce314a
d2814c0
d1828fa
769ce23
954b8dc
8c5cc77
64b6217
cab0fb3
76e4896
63193c3
1a9d3d0
b28be9c
addbe2f
f63e7e3
5aaea51
fe65d27
b93d2f2
86cf19a
3ce0a27
b6e5ad6
6ff1088
6052b7e
51b20a3
778fa22
3a40dfa
aa16f89
d0d3b77
6ee8a8d
2254dbf
2341543
23a8ee7
2423c91
cf2ae77
393f6b5
5887428
066c9fb
4b7ca80
72d6c09
00b6560
460de8e
240a1b6
3376677
232acc3
e516e65
03ce3ca
1958250
3fd9502
11cb635
4dee75d
25f47e4
8d2fe4b
2c9b9e6
2b14c66
649547c
c080c76
bd5de27
04336c1
1af94e7
5b35765
010aef9
7e5dad3
b1cbb40
3a7645c
d3b7aa6
31928ee
d5b95ed
741947c
4e3ce62
f1bf15a
b773e72
29130f6
754d06b
782bfe7
f9e6e22
571c1fa
ed82242
8314449
3947c27
22b6383
3baefd7
4b57937
d4cd49b
a682f3e
730b68b
e685190
6b983de
1a0b591
426f0cf
39b9d24
4050799
7469354
49dc1f3
c32469f
7616474
2a674aa
5b03b90
fa0aa90
05f4f52
86b2de8
d4f20c9
2ff1178
5491d1b
c787f84
fa383f5
08c67ed
9f914aa
36a9113
6cc5d90
00c8901
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, why is this
calc
needed here? It's the only line that usescalc
and I'm not exactly sure why. If I change it tomin(1.17vw, 8px)
, it seems to work just fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gabalafou the calc was added to this part of code because from the previous PR (#14626) @krassowski commented that the before changes meant the the UI was cutting off the menu on 100% zoom. So calc was added to fix this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If what this line does, specifically the
- 2px
part, cannot be explained, then I think it should be simplified. Or there should be some comment that explains what process was used to come up with these values.At the moment, I really can't understand why the
calc
expression is needed. If you domin(1.2vw, 8px)
, then the screen width has to drop to 666px before anything changes—because 0.012 * 666 < 8.Here is a screenshot showing that there's nothing wrong with the menu bar when I load this PR via GitPod and use Chrome Dev Tools to change the padding value to
0 min(1.2vw, 8px)
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gabalafou I have made the changes yo have recommend about taking out the calc from the padding. Please have a look, at the recent commit for the changes.