Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400% Zoom screen usability enhancements - Updated #14766

Closed
Closed
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
309 commits
Select commit Hold shift + click to select a range
dc6ddf2
changes to snapshot to match main branch
j264415 Oct 9, 2023
8e7c0cf
Merge branch 'jupyterlab:main' into high-zoom-test
j264415 Oct 10, 2023
ef536e9
clip viewport to show menbar only
j264415 Oct 10, 2023
5c2d84d
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Oct 10, 2023
9ec2efd
Update Playwright Snapshots
github-actions[bot] Oct 10, 2023
d642591
snapshot to match main, deleted previous low vision snapshot
j264415 Oct 10, 2023
bae2aa4
Merge branch 'jupyterlab:main' into high-zoom-test
j264415 Oct 12, 2023
0548f95
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Oct 12, 2023
469905b
Merge branch 'jupyterlab:main' into high-zoom-test
j264415 Oct 12, 2023
ac6c403
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Oct 12, 2023
e2253b4
Merge branch 'high-zoom-test' into low-vision-support-10004-version-2
j264415 Oct 12, 2023
b51bf2e
Update Playwright Snapshots
github-actions[bot] Oct 13, 2023
f27a147
Update Playwright Snapshots
github-actions[bot] Oct 13, 2023
a59c52f
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Oct 13, 2023
62d76b3
changed order of viewport height and width
j264415 Oct 13, 2023
1227434
changed menu-Item padding
j264415 Oct 16, 2023
95a7285
took out test.use
j264415 Oct 16, 2023
f97fc01
Update galata/test/jupyterlab/low-vision.test.ts
j264415 Oct 16, 2023
0e0d22a
Update galata/test/jupyterlab/low-vision.test.ts
j264415 Oct 16, 2023
321694a
Update Playwright Snapshots
github-actions[bot] Oct 16, 2023
e912df6
Update Playwright Snapshots
github-actions[bot] Oct 16, 2023
07053f1
changed file name, added commenta to css style, added launch screen f…
j264415 Oct 16, 2023
bf09e1e
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Oct 16, 2023
8df2d75
Update Playwright Snapshots
github-actions[bot] Oct 16, 2023
39ffb50
deleted snapshot
j264415 Oct 16, 2023
1cbb71a
changed padding values
j264415 Oct 16, 2023
aa06963
minor change
j264415 Oct 16, 2023
5df2df4
setViewport size
j264415 Oct 16, 2023
efd6180
Update Playwright Snapshots
github-actions[bot] Oct 17, 2023
c475e73
Update packages/application/style/sidepanel.css
j264415 Oct 17, 2023
d8265f9
Update packages/filebrowser/style/base.css
j264415 Oct 17, 2023
c3a0e88
Update packages/filebrowser/style/base.css
j264415 Oct 17, 2023
5c648b8
Update packages/filebrowser/style/base.css
j264415 Oct 17, 2023
f8a2c1d
Update packages/filebrowser/style/base.css
j264415 Oct 17, 2023
44d9ea7
Update packages/application/style/menus.css
j264415 Oct 17, 2023
e410bda
Update packages/filebrowser/style/base.css
j264415 Oct 17, 2023
e2dcab0
changes to get correct screen shot
j264415 Oct 17, 2023
45c545f
changed screenshot width
j264415 Oct 17, 2023
745dd05
changed viewport
j264415 Oct 17, 2023
9044dd6
took out unused variable
j264415 Oct 17, 2023
7ed43d8
Update Playwright Snapshots
github-actions[bot] Oct 17, 2023
dca42a0
different height and width
j264415 Oct 17, 2023
22122ff
Update Playwright Snapshots
github-actions[bot] Oct 17, 2023
3de71be
minor correction
j264415 Oct 17, 2023
2f4715a
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Oct 17, 2023
f4e6a1a
Update Playwright Snapshots
github-actions[bot] Oct 18, 2023
34446f7
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Oct 18, 2023
df6a6ab
added test.use for to set viewport values for this specified test
j264415 Oct 18, 2023
d2a898b
Update Playwright Snapshots
github-actions[bot] Oct 18, 2023
75e0c8a
clip changes
j264415 Oct 18, 2023
8f121a2
changed clip width value
j264415 Oct 18, 2023
b04b7f9
Update Playwright Snapshots
github-actions[bot] Oct 18, 2023
a1a362f
minor changes
j264415 Oct 18, 2023
0117fcc
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Oct 18, 2023
7a42213
Update Playwright Snapshots
github-actions[bot] Oct 19, 2023
b8495a7
changed with value
j264415 Oct 19, 2023
0bf18bf
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Oct 19, 2023
e23f08e
Update Playwright Snapshots
github-actions[bot] Oct 19, 2023
8d89626
getting full page screenshot
j264415 Oct 19, 2023
2aff43d
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Oct 19, 2023
e7ebbb1
Update Playwright Snapshots
github-actions[bot] Oct 19, 2023
240eb80
width and height calue changes
j264415 Oct 20, 2023
28398f0
took out zoom level line
j264415 Oct 20, 2023
adf5b3f
Update Playwright Snapshots
github-actions[bot] Oct 20, 2023
9fb91fb
add full page to menubar screenshot
j264415 Oct 20, 2023
e8758be
minor change
j264415 Oct 20, 2023
2ca51c7
Update Playwright Snapshots
github-actions[bot] Oct 20, 2023
4af5f58
changes
j264415 Oct 20, 2023
40015a1
Update Playwright Snapshots
github-actions[bot] Oct 20, 2023
1eafa89
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Oct 23, 2023
dd92b8f
testing changes
j264415 Oct 23, 2023
f1e5766
Update Playwright Snapshots
github-actions[bot] Oct 23, 2023
fb85ccc
removed fullPage: true
j264415 Oct 23, 2023
f765428
Update Playwright Snapshots
github-actions[bot] Oct 23, 2023
0794c74
yesting changes
j264415 Oct 23, 2023
ff2bdc6
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Oct 23, 2023
3ef7748
testing the tabbar screenshots
j264415 Oct 23, 2023
38032f5
Update Playwright Snapshots
github-actions[bot] Oct 23, 2023
e1a2f0a
added more screenshots of different areas of launch screen
j264415 Oct 23, 2023
a3a1d92
Update Playwright Snapshots
github-actions[bot] Oct 23, 2023
a121aaa
added light launch screen test snapshot
j264415 Oct 23, 2023
84f611b
took mistake out
j264415 Oct 24, 2023
0de7032
Update Playwright Snapshots
github-actions[bot] Oct 24, 2023
f48fea0
changes for menubar screenshot
j264415 Oct 24, 2023
ea4a304
Update Playwright Snapshots
github-actions[bot] Oct 24, 2023
00a407c
testing changes
j264415 Oct 24, 2023
df01261
Update Playwright Snapshots
github-actions[bot] Oct 24, 2023
7ec2d04
added snapshot for statusbar
j264415 Oct 25, 2023
472daeb
comment added
j264415 Oct 25, 2023
6774e82
Update Playwright Snapshots
github-actions[bot] Oct 25, 2023
c8ef84c
deleted unwanted snapshot
j264415 Oct 25, 2023
9a1bb67
fix conflict
j264415 Oct 25, 2023
1afe2be
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Oct 25, 2023
41f02d5
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Oct 26, 2023
bce16fe
Added comment for Calc expression
j264415 Oct 27, 2023
30b01dd
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Oct 27, 2023
7335fb3
fix conflict
j264415 Oct 30, 2023
47c02ab
removed irrelevant file changes
j264415 Oct 30, 2023
2469b2d
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Oct 30, 2023
2bb414d
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Nov 2, 2023
8088313
close sidebar for screenshot
j264415 Nov 2, 2023
23b0347
Update Playwright Snapshots
github-actions[bot] Nov 2, 2023
5cc4041
reverted chnages back
j264415 Nov 3, 2023
7dbbff6
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Nov 3, 2023
89b63ff
revert snapshot back to main
j264415 Nov 3, 2023
0e8487c
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 3, 2023
64a6371
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 3, 2023
53e2283
took out uneed import
j264415 Nov 3, 2023
afe4981
Update Playwright Snapshots
github-actions[bot] Nov 3, 2023
643f52b
close sidebar added
j264415 Nov 3, 2023
9ce275e
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Nov 3, 2023
f621d4d
more change
j264415 Nov 3, 2023
f2d6d24
Update Playwright Snapshots
github-actions[bot] Nov 3, 2023
04d5df9
took out dark themed snapshots
j264415 Nov 3, 2023
cb8079b
chanegs to vh, vw to fix space
j264415 Nov 3, 2023
e51cebf
Update Playwright Snapshots
github-actions[bot] Nov 3, 2023
ab5c98d
took unrelevant snapshots
j264415 Nov 3, 2023
22847a6
changed values of vw
j264415 Nov 6, 2023
95ab8e9
Update Playwright Snapshots
github-actions[bot] Nov 6, 2023
90f0de6
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Nov 6, 2023
baa39e4
removed duplicate snapshot
j264415 Nov 6, 2023
e5ce1cd
Update Playwright Snapshots
github-actions[bot] Nov 6, 2023
de84349
vw value channged
j264415 Nov 6, 2023
23e41c3
minor change
j264415 Nov 6, 2023
c2fa25e
Update Playwright Snapshots
github-actions[bot] Nov 6, 2023
1fc2656
minor changes
j264415 Nov 7, 2023
585ac23
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Nov 7, 2023
155d3f8
Update Playwright Snapshots
github-actions[bot] Nov 7, 2023
c3a6612
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Nov 7, 2023
e19bf11
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Nov 10, 2023
7cb79a5
minor change
j264415 Nov 13, 2023
e5bcdc8
Update Playwright Snapshots
github-actions[bot] Nov 13, 2023
a65f2ac
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Nov 13, 2023
60da49e
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 21, 2023
62d823f
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 21, 2023
5485c8b
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 21, 2023
6dbbf3e
Update packages/filebrowser/style/base.css
j264415 Nov 21, 2023
f004103
Update packages/filebrowser/style/base.css
j264415 Nov 21, 2023
ac3bf28
Update packages/filebrowser/style/base.css
j264415 Nov 21, 2023
4a2073f
Update packages/filebrowser/style/base.css
j264415 Nov 21, 2023
54871f9
Update packages/filebrowser/style/base.css
j264415 Nov 21, 2023
fce314a
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 21, 2023
d2814c0
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 21, 2023
d1828fa
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 21, 2023
769ce23
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 21, 2023
954b8dc
Update packages/application/style/menus.css
j264415 Nov 21, 2023
8c5cc77
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 21, 2023
64b6217
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 21, 2023
cab0fb3
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 21, 2023
76e4896
Update packages/application/style/sidepanel.css
j264415 Nov 21, 2023
63193c3
fixed conlfuct files and made review changes
j264415 Nov 21, 2023
1a9d3d0
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 21, 2023
b28be9c
Update galata/test/jupyterlab/zoom.test.ts
j264415 Nov 21, 2023
addbe2f
Merge remote-tracking branch 'origin/main' into low-vision-support-10…
j264415 Nov 21, 2023
f63e7e3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 21, 2023
5aaea51
added comment for test.use
j264415 Nov 21, 2023
fe65d27
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Nov 21, 2023
b93d2f2
Update Playwright Snapshots
github-actions[bot] Nov 21, 2023
86cf19a
removed duplicate snapshot and unnecessary file changes
j264415 Nov 21, 2023
3ce0a27
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Nov 28, 2023
b6e5ad6
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Nov 28, 2023
6ff1088
Lint the code
fcollonval Nov 29, 2023
6052b7e
Update Playwright Snapshots
github-actions[bot] Nov 29, 2023
51b20a3
Update Playwright Snapshots
github-actions[bot] Nov 29, 2023
778fa22
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Nov 30, 2023
3a40dfa
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Dec 1, 2023
aa16f89
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Dec 4, 2023
d0d3b77
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Dec 7, 2023
6ee8a8d
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Dec 13, 2023
2254dbf
fixed conflict
j264415 Dec 13, 2023
2341543
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Dec 14, 2023
23a8ee7
fixed conflict of file
j264415 Dec 15, 2023
2423c91
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Dec 15, 2023
cf2ae77
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Dec 19, 2023
393f6b5
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Dec 20, 2023
5887428
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 8, 2024
066c9fb
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 9, 2024
4b7ca80
adjusted row gap values
j264415 Jan 9, 2024
72d6c09
commented out row-gap
j264415 Jan 9, 2024
00b6560
reverted changes back
j264415 Jan 9, 2024
460de8e
change made
j264415 Jan 9, 2024
240a1b6
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 10, 2024
3376677
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 11, 2024
232acc3
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 15, 2024
e516e65
Merge branch 'main' into low-vision-support-10004-version-2
j264415 Jan 15, 2024
03ce3ca
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 16, 2024
1958250
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 18, 2024
3fd9502
Update Playwright Snapshots
github-actions[bot] Jan 18, 2024
11cb635
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 19, 2024
4dee75d
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 22, 2024
25f47e4
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 23, 2024
8d2fe4b
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 25, 2024
2c9b9e6
changes to vh and vw to fix snapshot problem
j264415 Jan 25, 2024
2b14c66
Update Playwright Snapshots
github-actions[bot] Jan 25, 2024
649547c
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 25, 2024
c080c76
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 26, 2024
bd5de27
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 29, 2024
04336c1
deleted the full main page at 400% zoom
j264415 Jan 29, 2024
1af94e7
changes to calc values to fic padding cutt off
j264415 Jan 29, 2024
5b35765
Update Playwright Snapshots
github-actions[bot] Jan 29, 2024
010aef9
resolved conflict in files
j264415 Jan 30, 2024
7e5dad3
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 30, 2024
b1cbb40
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Jan 31, 2024
3a7645c
added full page SC and menu bar clipped from full page SC for testing
j264415 Jan 31, 2024
d3b7aa6
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Jan 31, 2024
31928ee
Update Playwright Snapshots
github-actions[bot] Jan 31, 2024
d5b95ed
changes clipped height
j264415 Jan 31, 2024
741947c
Update Playwright Snapshots
github-actions[bot] Jan 31, 2024
4e3ce62
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Feb 1, 2024
f1bf15a
commented out the flex-wrap and row-gap css to test SC changes.
j264415 Feb 1, 2024
b773e72
Update Playwright Snapshots
github-actions[bot] Feb 1, 2024
29130f6
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Feb 2, 2024
754d06b
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Feb 5, 2024
782bfe7
Update Playwright Snapshots
github-actions[bot] Feb 5, 2024
f9e6e22
margin change of vh and vw
j264415 Feb 5, 2024
571c1fa
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Feb 5, 2024
ed82242
Update Playwright Snapshots
github-actions[bot] Feb 5, 2024
8314449
increased menu bar screenshot to test cut off of menu bar
j264415 Feb 6, 2024
3947c27
Merge branch 'low-vision-support-10004-version-2' of github.com:j2644…
j264415 Feb 6, 2024
22b6383
Merge branch 'main' into low-vision-support-10004-version-2
j264415 Feb 6, 2024
3baefd7
Update Playwright Snapshots
github-actions[bot] Feb 6, 2024
4b57937
fix to help memu being cropped off
j264415 Feb 6, 2024
d4cd49b
Update Playwright Snapshots
github-actions[bot] Feb 6, 2024
a682f3e
deleted unneed zoom snapshot files
j264415 Feb 6, 2024
730b68b
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Feb 14, 2024
e685190
padding changes to menu bar
g547315 Feb 22, 2024
6b983de
padding changes to side panel
g547315 Feb 22, 2024
1a0b591
margin changes to .jp-FileBrowser-toolbar.jp-Toolbar
g547315 Feb 22, 2024
426f0cf
padding chnages to .jp-DirListing-headerItem
g547315 Feb 22, 2024
39b9d24
margin changes for .jp-BreadCrumbs {
g547315 Feb 22, 2024
4050799
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Feb 23, 2024
7469354
Merge branch 'low-vision-support-10004-version-2' into 400%-zoom-low-…
j264415 Feb 23, 2024
49dc1f3
Merge pull request #2 from g547315/400%-zoom-low-vision
j264415 Feb 23, 2024
c32469f
Update Playwright Snapshots
github-actions[bot] Feb 23, 2024
7616474
changed width and height
j264415 Feb 28, 2024
2a674aa
Update Playwright Snapshots
github-actions[bot] Feb 28, 2024
5b03b90
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Feb 28, 2024
fa0aa90
fixed unnecessary snapshots
j264415 Mar 4, 2024
05f4f52
Merge branch 'main' into low-vision-support-10004-version-2
j264415 Mar 4, 2024
86b2de8
Update Playwright Snapshots
github-actions[bot] Mar 4, 2024
d4f20c9
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Mar 4, 2024
2ff1178
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Mar 11, 2024
5491d1b
Merge branch 'main' into low-vision-support-10004-version-2
g547315 Mar 13, 2024
c787f84
Update packages/application/style/menus.css
g547315 Mar 13, 2024
fa383f5
Update packages/filebrowser/style/base.css
g547315 Mar 13, 2024
08c67ed
comment code changes
j264415 Mar 13, 2024
9f914aa
Update Playwright Snapshots
github-actions[bot] Mar 13, 2024
36a9113
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Mar 13, 2024
6cc5d90
Update Playwright Snapshots
github-actions[bot] Mar 13, 2024
00c8901
Merge branch 'jupyterlab:main' into low-vision-support-10004-version-2
j264415 Mar 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion packages/application/style/menus.css
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
}

.lm-MenuBar-item {
padding: 0 8px;
/* stylelint-disable-next-line csstree/validator */
j264415 marked this conversation as resolved.
Show resolved Hide resolved
g547315 marked this conversation as resolved.
Show resolved Hide resolved
padding: 0 min(calc(1.17vw - 2px), 8px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, why is this calc needed here? It's the only line that uses calc and I'm not exactly sure why. If I change it to min(1.17vw, 8px), it seems to work just fine.

Copy link
Contributor Author

@j264415 j264415 Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gabalafou the calc was added to this part of code because from the previous PR (#14626) @krassowski commented that the before changes meant the the UI was cutting off the menu on 100% zoom. So calc was added to fix this issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If what this line does, specifically the - 2px part, cannot be explained, then I think it should be simplified. Or there should be some comment that explains what process was used to come up with these values.

At the moment, I really can't understand why the calc expression is needed. If you do min(1.2vw, 8px), then the screen width has to drop to 666px before anything changes—because 0.012 * 666 < 8.

Here is a screenshot showing that there's nothing wrong with the menu bar when I load this PR via GitPod and use Chrome Dev Tools to change the padding value to 0 min(1.2vw, 8px):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gabalafou I have made the changes yo have recommend about taking out the calc from the padding. Please have a look, at the recent commit for the changes.

border-left: var(--jp-border-width) solid transparent;
border-right: var(--jp-border-width) solid transparent;
border-top: var(--jp-border-width) solid transparent;
Expand Down
3 changes: 2 additions & 1 deletion packages/application/style/sidepanel.css
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
}

.jp-SideBar .lm-TabBar-tab {
padding: 16px 0;
/* stylelint-disable-next-line csstree/validator */
j264415 marked this conversation as resolved.
Show resolved Hide resolved
padding: min(2vh, 16px) 0;
border: none;
overflow: visible;
flex-direction: column;
Expand Down
15 changes: 10 additions & 5 deletions packages/filebrowser/style/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@

.jp-FileBrowser-toolbar.jp-Toolbar {
flex-wrap: wrap;
row-gap: 12px;
/* stylelint-disable-next-line csstree/validator */
j264415 marked this conversation as resolved.
Show resolved Hide resolved
row-gap: min(1.5vh, 12px);
border-bottom: none;
height: auto;
margin: 8px 12px 0;
/* stylelint-disable-next-line csstree/validator */
j264415 marked this conversation as resolved.
Show resolved Hide resolved
margin: min(1vh, 8px) min(1.5vw, 12px) 0;
box-shadow: none;
padding: 0;
justify-content: flex-start;
Expand All @@ -41,7 +43,8 @@

.jp-BreadCrumbs {
flex: 0 0 auto;
margin: 8px 12px;
/* stylelint-disable-next-line csstree/validator */
j264415 marked this conversation as resolved.
Show resolved Hide resolved
margin: min(1vh, 8px) min(1vw, 12px);
}

.jp-BreadCrumbs-item {
Expand Down Expand Up @@ -128,7 +131,8 @@
}

.jp-DirListing-headerItem {
padding: 4px 12px 2px;
/* stylelint-disable-next-line csstree/validator */
j264415 marked this conversation as resolved.
Show resolved Hide resolved
padding: min(1vh, 4px) min(1vw, 12px) min(0.5vh, 2px);
font-weight: 500;
}

Expand Down Expand Up @@ -205,7 +209,8 @@
display: flex;
flex-direction: row;
align-items: center;
padding: 4px 12px;
/* stylelint-disable-next-line csstree/validator */
j264415 marked this conversation as resolved.
Show resolved Hide resolved
padding: min(1vh, 4px) min(1vw, 12px);
-webkit-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
Expand Down
Loading