Fix windowed notebook and ToC getting broken on reloading from disk #16013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
even though `cellRef` has changed (which led to ToC broken on reload)
|
Thanks for making a pull request to jupyterlab! |
Adds missing guard for not going into the soft detach mode when the cell is scheduled to be removed altogether
jtpio
approved these changes
Mar 22, 2024
krassowski
added a commit
to krassowski/jupyterlab
that referenced
this pull request
Apr 19, 2024
krassowski
added a commit
that referenced
this pull request
Apr 19, 2024
ImpSy
pushed a commit
to spotinst/jupyterlab
that referenced
this pull request
Jan 7, 2025
…upyterlab#16013) * Add jest test for Notebook ToC situation * Fix Notebook headings being incorrectly considered as equal even though `cellRef` has changed (which led to ToC broken on reload) * Fix detaching active cell when it is pending removal Adds missing guard for not going into the soft detach mode when the cell is scheduled to be removed altogether
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #15415
Code changes
headingsChangedbeing emitted byNotebookToCModelon cell insertion, deletion and reloading the modelTableOfContentsModel.isHeadingEqual()method which can be overridden in subclasseswidget !== this._willBeRemovedin the conditional check sensing if the active cell should be softly detached (or removed)User-facing changes
ToC/windowing works well when pressing "Revert" button.
Backwards-incompatible changes
None