Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade packaging #178

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Upgrade packaging #178

merged 1 commit into from
Apr 19, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 19, 2021

  • Use jupyter_packaging and recommended setup.cfg metadata
  • Use tbump to handle versioning and test in CI
  • Add check-manifest support and test in CI

@blink1073 blink1073 merged commit 1d6ea50 into jupyterlab:master Apr 19, 2021
blink1073
blink1073 reviewed Apr 19, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio deleted the packaging branch April 19, 2021 11:42
@blink1073 blink1073 added this to the 2.5 milestone Apr 26, 2021
@bollwyvl
Copy link
Contributor

I guess we're shipping it, but I dislike the creep of jupyter_packaging with weird version constraints into runtime dependencies to get __version__.split('.')... also kinda looks like the runtime version spec might not be saying what we think it's saying anyhow, as ~0.9,<2 still says >=9,<1 to my eyes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@jtpio @bollwyvl @blink1073