Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class and aria attribute must be changed on title #232

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Class and aria attribute must be changed on title #232

merged 1 commit into from
Sep 14, 2021

Conversation

fcollonval
Copy link
Member

@jupyterlab-probot
Copy link

Thanks for making a pull request to lumino!
To try out this branch on binder, follow this link: Binder

blink1073
blink1073 approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added the bug Something isn't working label Sep 14, 2021
@blink1073 blink1073 merged commit 1c8b122 into jupyterlab:master Sep 14, 2021
@trungleduc
Copy link
Member

Thanks @fcollonval for fixing it, will this pass go live soon?

@fcollonval fcollonval deleted the fix/accordion-expand-class branch September 15, 2021 09:00
@fcollonval fcollonval mentioned this pull request Sep 15, 2021
Merged
@blink1073
Copy link
Contributor

will this pass go live soon?

I was waiting for #231 since it was filed on the same day.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fcollonval @trungleduc @blink1073