Add capability for KeyboardEvent.code + capture #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
KeycodeLayout
to also use thecode
field fromKeyboardEvents
. It still allows for adding keyCode values to the map, both for backwards compatibility, but also since there are some keys that will not have acode
value (it will be either an empty string or "Unidentified").code
fields for EN_US.key
field fromKeyboardEvents
onto the list of "Special Keys" from the spec. This is only considered if there are no match for the event via thecode
/keyCode
fields.Resolves #74.
TODOs:
Find a way to explicitly prompt for a key value for "Dead" keys. This might need some extra thought to catch corner cases.We should not try to capture Dead keys, as they are unsuitable for use in shortcuts.isComposition
is relevant. Capture any behavior in tests.