Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR illustrates the changes needed to allow
jupyterlab
to be statically included inremix.run
application and bundled within server code. relates to issue #470The changes here obviously may not leave the application in a functional state or apply good defaults, but they enable bundling / building and subsequent use in client-only parts of a remix / next.js based web application.
Hopefully these are useful as a guide in how to update / change intiialisaiton of some parts of lumino so there there is no dependency on browser globals at import time.
Note: these changes were determined from a specific use case, where
domutils
was pulled in as a dependency, there may be other similar issues in other lumino packages that need to be considered.