Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added guards for browser globals #471

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stevejpurves
Copy link

@stevejpurves stevejpurves commented Nov 23, 2022

This draft PR illustrates the changes needed to allow jupyterlab to be statically included in remix.run application and bundled within server code. relates to issue #470

The changes here obviously may not leave the application in a functional state or apply good defaults, but they enable bundling / building and subsequent use in client-only parts of a remix / next.js based web application.

Hopefully these are useful as a guide in how to update / change intiialisaiton of some parts of lumino so there there is no dependency on browser globals at import time.

Note: these changes were determined from a specific use case, where domutils was pulled in as a dependency, there may be other similar issues in other lumino packages that need to be considered.

@welcome
Copy link

welcome bot commented Nov 23, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@fcollonval fcollonval added the enhancement New feature or request label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants