Added type search to command pallet search input

[ggbhat]

Fixes - #56
Jupyter Lab Issue - 6617

Added type search to input to show clear search icon. It will solve usability issue by user should be able to use mouse click to clear search text.

[blink1073]

cc @tgeorgeux

[vidartf]

What happened to our binder bot? :(

I cannot see such a cross when testing here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/search (Win 10, Firefox).

[ggbhat]

@vidartf Yeah, clear search is not available for firefox. Need to add custom clear button then.

[ggbhat]

Added custom clear search button since input type search is not works on Firefox.

[jasongrout]

Added custom clear search button since input type search is not works on Firefox.

input type search definitely works in Firefox, since Firefox 4, IIRC. However, having a clear button is one of the differences between browsers: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/search#Differences_between_search_and_text_types

[jasongrout]

See also https://bugzilla.mozilla.org/show_bug.cgi?id=558594 (which has seen recent work) and https://stackoverflow.com/a/46687047

[tgeorgeux]

I am overtly +1 on this, provided it's technically sound, (which I am far from qualified to assess).

[blink1073]

Thanks!