Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "tabindex=0" for sidebar accessibility #583

Merged
merged 3 commits into from
May 20, 2023
Merged

Added "tabindex=0" for sidebar accessibility #583

merged 3 commits into from
May 20, 2023

Conversation

j264415
Copy link
Contributor

@j264415 j264415 commented May 9, 2023 •
edited
Loading

References
#9686 and #1440

Code changes
Easy part of #9686: added labels and tabindex="0" for sidebar elements so screen-readers can access them.

@krassowski Please review and comment to see if these are the right changes needed.

@welcome
Copy link

welcome bot commented May 9, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@j264415 j264415 changed the title Added "tabindex=0" for sidebar accessibility Added "tabindex=0" for sidebar accessibility @meeseeksdev "accessibility" May 10, 2023
@j264415 j264415 changed the title Added "tabindex=0" for sidebar accessibility @meeseeksdev "accessibility" Added "tabindex=0" for sidebar accessibility @meeseeksdev foo "accessibility" May 10, 2023
@j264415 j264415 changed the title Added "tabindex=0" for sidebar accessibility @meeseeksdev foo "accessibility" Added "tabindex=0" for sidebar accessibility @meeseeksdev tag "accessibility" May 10, 2023
@j264415 j264415 changed the title Added "tabindex=0" for sidebar accessibility @meeseeksdev tag "accessibility" Added "tabindex=0" for sidebar accessibility May 10, 2023
@j264415 j264415 marked this pull request as draft May 10, 2023 14:36
@j264415 j264415 closed this May 10, 2023
@j264415 j264415 reopened this May 10, 2023
@j264415
Copy link
Contributor Author

j264415 commented May 10, 2023

@meeseeksdev tag accessibility

@lumberbot-app
Copy link

lumberbot-app bot commented May 10, 2023

Awww, sorry j264415 you do not seem to be allowed to do that, please ask a repository maintainer.

@j264415 j264415 marked this pull request as ready for review May 10, 2023 14:50
@krassowski krassowski added accessibility Addresses accessibility needs enhancement New feature or request labels May 11, 2023
krassowski
krassowski approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @j264415! I pushed a commit to fix the failing API changes test. In future, to fix it you can run: yarn run api and commit the changes.

CC @gabalafou for awareness

@krassowski krassowski merged commit 57a7cbc into jupyterlab:main May 20, 2023
@welcome
Copy link

welcome bot commented May 20, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@brichet brichet mentioned this pull request Jun 28, 2023
Closed
@brichet brichet mentioned this pull request Jul 20, 2023
Merged
@g547315 g547315 mentioned this pull request Sep 1, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krassowski krassowski krassowski approved these changes

Assignees

@j264415 j264415

Labels
accessibility Addresses accessibility needs enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j264415 @krassowski