Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebooks directory with example Typescript notebook. #8

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

ellisonbg
Copy link
Contributor

This PR adds a notebooks directory with configuration to write notebooks in TypeScript that can import from the local lumino packages. There is a sample notebook that does some tests of different serialization schemes for indices. The goal would be to start adding notebook-based narrative documentation for lumino (at least the parts that don't need to render things to the page.

@vidartf
Copy link
Member

vidartf commented Nov 28, 2019

Thanks for sharing the profiling code! That's useful.

The goal would be to start adding notebook-based narrative documentation for lumino (at least the parts that don't need to render things to the page.

I have a few reservations about that. I might become convinced that having some explanations written as a notebook can have merit, but I don't think it is a good idea to switch to using a non-Node based tool as the main way for writing the docs.

@ellisonbg
Copy link
Contributor Author

ellisonbg commented Nov 28, 2019 via email

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 7999d83 into jupyterlab:master Dec 3, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants