-
-
Notifications
You must be signed in to change notification settings - Fork 46
Enable auto scrolling for outputs by default #288
Conversation
Trying to match classic makes sense here. I think we should eventually upstream this into lab, but this is a great place to try this out. Thanks a lot for looking into this, @jtpio |
There is some logic in the |
0f4f459
to
2c7f677
Compare
A follow-up to this would be to update to JupyterLab 3.2.5 packages to grab jupyterlab/jupyterlab#11478 |
Opened jupyterlab/jupyterlab#11760 to track that upstream. |
cc @yuvipanda if you want to give it a try on Binder: https://mybinder.org/v2/gh/jtpio/retrolab/scroll-outputs?urlpath=retro/tree I'll do a bit more testing but if it works fine we can merge and release. Thinking we might also want to make it possible to disable that behavior via the settings system (opt-out). |
Implemented in 84df24d |
Did some more testing on Binder and it seems to be working fine. Will make a new release with this change after merging. |
Fixes #287
autoscroll-outputs.mp4
TODO
cc @yuvipanda