Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

[wip] include npm tarballs in dist #69

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jan 6, 2021

Hooray continuing to publish on npm and not build another walled garden!

This builds and includes the npm tarballs in the dist artifact... these can be directly uploaded with (npm|lerna) publish (or whatever, i always forget), and has the advantage of what is published being exactly what was tested, instead of whatever happens to be on a developer's box at the time. I've learned this the hard way a few times 😊 .

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 6, 2021

Hooray 🟢 .

Actually had a look at the dists (ha): of note, the npm tarballs don't include LICENSE in package.json/files, but seems out of scope for this... and indeed, neither does lab core. We need to deal with that, as developers forget and then downstream package managers 😉 have to pick up the shiny pieces (looking at you, rust/go/coursier).

@jtpio
Copy link
Member

jtpio commented Jan 7, 2021

Nice, thanks again @bollwyvl for this, this is great!

@jtpio jtpio merged commit 1497d80 into jupyterlab:main Jan 7, 2021
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 7, 2021 via email

@jtpio
Copy link
Member

jtpio commented Jan 7, 2021

Thanks, I will most likely adopt it in other repos too!

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 7, 2021 via email

@jtpio
Copy link
Member

jtpio commented Jan 7, 2021

An issue on the team compass sounds good 👍

It would be nice to have this as some kind of reusable component yes. Something that could complement other aspects of testing such as jupyterlab/frontends-team-compass#77

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants