Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload to a user-provided uploadpath #26

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Conversation

juntyr
Copy link
Contributor

@juntyr juntyr commented Nov 22, 2024

Upload the repository to a user-provided uploadpath, which is given as an optional query parameter. The directory PathExt.join(uploadPath, PathExt.basename(repo)) is created. By default, uploadpath is '/', i.e. the repository is uploaded to PathExt.basename(repo) as before.

Supersedes #25.

If a nested basepath `'a/b/c'` is given and does not exist yet, all directories in the basepath will be created, similar to using `mkdir -p`
Copy link

Binder 👈 Launch a Binder on branch juntyr/litegitpuller/patch-2

@juntyr juntyr mentioned this pull request Nov 22, 2024
27 tasks
@juntyr
Copy link
Contributor Author

juntyr commented Nov 25, 2024

@brichet What do you think about this approach?

@brichet brichet added the enhancement New feature or request label Nov 25, 2024
@brichet
Copy link
Collaborator

brichet commented Nov 25, 2024

Thanks @juntyr, this looks great.

Does it for for you with nested uploadpath in jupyter-lite ?
On my side it is not stable, and often fails strangely: the notebook opens, but the repo is not available in the tree...

I believe that we are missing an await here.

@juntyr
Copy link
Contributor Author

juntyr commented Nov 25, 2024

I believe that we are missing an await here.

Good catch! I tried to go through all litegitpuller code again and see if there’s any other missing awaits.

Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@brichet brichet merged commit 6d32604 into jupyterlite:main Nov 25, 2024
8 checks passed
@juntyr juntyr deleted the patch-2 branch November 25, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants