Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminals not displayed in tree view #6

Closed
ianthomas23 opened this issue May 29, 2024 · 2 comments · Fixed by #11
Closed

Terminals not displayed in tree view #6

ianthomas23 opened this issue May 29, 2024 · 2 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@ianthomas23
Copy link
Member

Opened terminals do not appear in the TERMINALS section of the tree view on the left-hand side of jupyterlite.

@ianthomas23 ianthomas23 added the bug Something isn't working label May 29, 2024
@jtpio
Copy link
Member

jtpio commented May 29, 2024

We probably need to implement another route that lists the open terminals.

@jtpio
Copy link
Member

jtpio commented May 30, 2024

Looks like it's already implemented though:

/**
* List the running terminals.
*/
async list(): Promise<TerminalAPI.IModel[]> {
const ret = [...this._terminals.values()].map(terminal => ({
name: terminal.name
}));
console.log('==> Terminals.list', ret);
return ret;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants