Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix listing of terminals #11

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix listing of terminals #11

merged 1 commit into from
May 30, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 30, 2024

Fixes #6

image

@jtpio jtpio added the bug Something isn't working label May 30, 2024
@jtpio jtpio mentioned this pull request May 30, 2024
Open
@jtpio jtpio requested a review from ianthomas23 May 30, 2024 08:37
@ianthomas23
Copy link
Member

Ah, the bane of swapping between Python and JavaScript async code and being constantly surprised by the differences!

ianthomas23
ianthomas23 approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@ianthomas23 ianthomas23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio!

@jtpio jtpio merged commit 8ec862a into jupyterlite:main May 30, 2024
9 checks passed
@jtpio jtpio deleted the list branch May 30, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthomas23 ianthomas23 ianthomas23 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terminals not displayed in tree view
2 participants
@jtpio @ianthomas23