-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove WebWorker code that is now in cockle #21
Conversation
This now works, the Now we are using the WebWorker Also this includes an extra build stage to copy the WASM files and their associated JS wrappers into the correct directory so they are served at the expected URIs for dynamic loading using To try this out locally still requires the use of
We still need some solution along these lines for the hosting of the demo site in github pages. |
mountpoint: '/drive', | ||
driveFsBaseUrl: options.baseUrl, | ||
wasmBaseUrl: | ||
options.baseUrl + 'extensions/@jupyterlite/terminal/static/wasm/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path is currently hardcoded and works OK for default installations. I am not sure if the extension path is configurable and if so, we'll need to obtain this dynamically at runtime.
This is an attempt to upgrade from cockle 0.0.5 to 0.0.7. The WebWorker code is now in cockle and hence needs to be removed from this repo, making this much simpler.
It is not yet working as the WebWorker is not yet being initialised correctly. Originally I thought this was a problem with the
worker.webpack.config.js
but I don't believe this is required any longer as the normal build process creates the webworker JS file in the correct place in the_output
directory. I have confirmed this by replacing the cockleshell_impl.js
with something much simpler that has no dependencies and just writes some debug messages to the console, and that works fine. So the problem appears to be with webpack trying to load@jupyterlite/contents
which is seems to do recursively.I am experimenting with setting this package as one of thesingletonPackages
.