Support use of em-forge wasm files in standalone JupyterLite deployment #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Following this there is a successful deployment on vercel at https://jlite-vercel.vercel.app/lab/index.html, repo is https://github.com/ianthomas23/jlite-vercel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes in
cockleto support use of Emscripten-forge wasm files in the terminal (jupyterlite/cockle#61) work fine in thecockleandterminalrepositories but do not work in a standalone JupyterLite deployment as they rely oncocklebeing available locally innode_modules. This is a workaround to support that use case by checking if the requiredcocklefile is installed locally innode_modulesand if it is not, it installs it in a temporary directory.cockle_temp. This is not a good workaround as it unnecessarily installs a set ofnpmdependencies, but it is better to have such standalone deployments working than not, and we can revisit this later with a better solution.After merging this will need a new release of the
terminalpackages so that it can be tried out in a standalone deployment.