Skip to content

Commit

Permalink
Fix empack custom config support (#139)
Browse files Browse the repository at this point in the history
* Fix empack config support

* Bump empack

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
martinRenou and github-actions[bot] authored Jan 9, 2025
1 parent 9eeb6fb commit 528fe3f
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions jupyterlite_xeus/add_on.py
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,8 @@ def pack_prefix(self, kernel_dir):
empack_config_is_url = urlparse(empack_config).scheme in ("http", "https")
if empack_config_is_url:
empack_config_content = requests.get(empack_config).content
pack_kwargs["file_filters"] = PkgFileFilter.parse_obj(
yaml.safe_load(empack_config_content)
pack_kwargs["file_filters"] = PkgFileFilter(
**yaml.safe_load(empack_config_content)
)
else:
pack_kwargs["file_filters"] = pkg_file_filter_from_yaml(empack_config)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ classifiers = [
"Programming Language :: Python :: 3.12",
]
dependencies = [
"empack>=4.0.2,<6",
"empack>=5,<6",
"traitlets",
"jupyterlite-core>=0.1,<0.6",
"pyyaml",
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 528fe3f

Please sign in to comment.