Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p7zip is preinstalled in macos #245

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

batcaveMessi
Copy link
Contributor

@batcaveMessi batcaveMessi commented Jun 17, 2024

Copy link
Contributor

@pzhlkj6612 pzhlkj6612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR.

And I'm confused why we needed "p7zip" on macOS. I read the docs of py7zr but didn't see the requirement of "p7zip". Maybe I'm missing something?

Is "p7zip" related to External 7-zip extractor § Getting Started — aqtinstall 3.1.16 documentation ?

@batcaveMessi
Copy link
Contributor Author

Nice PR.

And I'm confused why we needed "p7zip" on macOS. I read the docs of py7zr but didn't see the requirement of "p7zip". Maybe I'm missing something?

Is "p7zip" related to External 7-zip extractor § Getting Started — aqtinstall 3.1.16 documentation ?

My guess is, in the earlier versions of macOS GitHub runners, they did not have p7zip, which is used by aqtinstall action so they had to install it every time. In the latest macOS p7zip is pre-installed. Unfortunately, that is pretty much everything I know about this.

@jurplel jurplel merged commit 9f24772 into jurplel:master Jul 13, 2024
80 of 82 checks passed
@batcaveMessi batcaveMessi deleted the patch-1 branch July 19, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants