generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ARM64 hosts #273
Open
jdpurcell
wants to merge
9
commits into
jurplel:master
Choose a base branch
from
jdpurcell:arm64-hosts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support ARM64 hosts #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdpurcell
force-pushed
the
arm64-hosts
branch
from
January 19, 2025 00:54
513e2e3
to
ccf95d9
Compare
jdpurcell
commented
Jan 19, 2025
@@ -123,7 +128,7 @@ jobs: | |||
dir: ${{ matrix.dir }} | |||
modules: ${{ matrix.qt.modules }} | |||
version: ${{ matrix.qt.requested }} | |||
tools: tools_ifw tools_qtcreator,qt.tools.qtcreator | |||
tools: tools_ifw tools_qtcreator_gui,qt.tools.qtcreator_gui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name seems to have changed a while back; tools_qtcreator
doesn't exist for ARM64 Linux and references version 9.0 on other platforms. tools_qtcreator_gui
is for the latest version (15.0 at the moment).
Awesome work @jdpurcell ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248. This PR is based on #268 hence the unrelated commits due to overlapping work in
requiresParallelDesktop
. Once the other is merged, we can get the unrelated commits to drop off and you'll only see the latest 2 commits here. (GitHub doesn't do this automatically upon merge, but it doesn't require a true rebase; simply click the Edit button next to the PR title, click thebase: master
dropdown, click themaster
branch, and clickChange base
). If you don't want to merge #268 first or at all, let me know and I can redo the work onmaster
.The Linux part is working fine, I already have my
kimageformats-binaries
andqView
forks using it and building a working aarch64 AppImage. I haven't tested the Windows part since the ARM64 Windows runners aren't public yet.