Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO redirect new user to welcome wizard #326

Open
tyagishuchi1 opened this issue Jul 21, 2020 · 4 comments
Open

TODO redirect new user to welcome wizard #326

tyagishuchi1 opened this issue Jul 21, 2020 · 4 comments
Labels
enhancement Improvement on existing feature

Comments

@tyagishuchi1
Copy link

tyagishuchi1 commented Jul 21, 2020

The page keeps loading and does not provide a proper response to users if a new user tries to access a URL other than the homepage directly. (without going through the welcome wizard/ accepting disclaimer/accepting terms and conditions )

Expected Behavior

If any new user tries to access a URL (other than the homepage) directly, they should be redirected to the welcome wizard page.

Steps to Reproduce

Environment: Temp

  1. Create a new wallet
  2. Access any URL expect the homepage
@tyagishuchi1 tyagishuchi1 added the enhancement Improvement on existing feature label Jul 21, 2020
@tyagishuchi1 tyagishuchi1 added this to the Advocate + Reward milestone Jul 21, 2020
@ashishjur
Copy link

@MirelXhafa can you take this one?

@MirelXhafa
Copy link

@ashishjur yes i will take a look at this

@ashishjur
Copy link

@MirelXhafa Ping me tomorrow whenever you start work. Let me know if you have any queries about this issue. We will talk this on the call.

@tyagishuchi1
Copy link
Author

tyagishuchi1 commented Jul 28, 2020

@MirelXhafa Mentioning the points discussed today:

  1. The wizard is currently shown based on a cookie value.
  2. It is most probably only implemented for contracts right now.
  3. We have to move the logic to a move global component so that all pages are covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

No branches or pull requests

3 participants