feat: transfer docker images from public registries to aws private ECR #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inventvenkat
requested changes
Feb 29, 2024
| phases: | ||
| pre_build: | ||
| commands: | ||
| - echo "Logging in to the docker" |
There was a problem hiding this comment.
Can we remove this echo?
| - echo "Logging in to the docker" | ||
| build: | ||
| commands: | ||
| - echo "Building and pushing Docker images" |
There was a problem hiding this comment.
the message in the echo is different from the operations followed. Please use the proper comments
There was a problem hiding this comment.
It's not required, we can remove it
lib/aws/eks.ts
Outdated
| statements: [ | ||
| new iam.PolicyStatement({ | ||
| actions: [ | ||
| "ecr:*", |
There was a problem hiding this comment.
Can you give the exact permissions, instead of all
inventvenkat
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.