fix(rds): restrict RDS inbound access by removing open IP rule #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagan-jaya
reviewed
Feb 16, 2024
| @@ -295,6 +295,8 @@ while true; do | |||
|
|
|||
| done | |||
|
|
|||
| export AWS_DEFAULT_REGION; | |||
There was a problem hiding this comment.
In few cases if AWS_DEFAULT_REGION is not exported by the user. CDK is not populating CDK_DEFAULT_REGION. So, just to ignore the case where the user didn't export AWS_DEFAULT_REGION I am doing it in the script.
|
|
||
| let rds = new DataBaseConstruct(this, config.rds, vpc.vpc, isStandalone); | ||
| if (isStandalone) { | ||
| rds.sg.addIngressRule(ec2.Peer.ipv4("0.0.0.0/0"), ec2.Port.tcp(5432)); // this has to be moved to standalone and for production it should be internal jump |
There was a problem hiding this comment.
we need to remove in other places also right?
There was a problem hiding this comment.
As this PR is RDS Specific, Removing here would suffice. I have created a separate issue for restricting external jump and internal jump public access.
jagan-jaya
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.