Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pagobancomat card scheme regex addition #600

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Sanskar2001
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

Copy link

semanticdiff-com bot commented Sep 4, 2024

Review changes with  SemanticDiff

{
issuer: "PagoBancomat",
pattern: %re(
"/^(10051\d{5}|10053\d{5}|10108\d{5}|10150\d{5}|10258\d{5}|10300\d{5}|10309\d{5}|20083\d{5}|20084\d{5}|20085\d{5}|20089\d{5}|30150\d{5}|30190\d{5}|30320\d{5}|30430\d{5}|30439\d{5}|30480\d{5}|30583\d{5}|30589\d{5}|30590\d{5}|30620\d{5}|30670\d{5}|30690\d{5}|30750\d{5}|30830\d{5}|30836\d{5}|30870\d{5}|31040\d{5}|31110\d{5}|31240\d{5}|31260\d{5}|31270\d{5}|31380\d{5}|31580\d{5}|31599\d{5}|31850\d{5}|32040\d{5}|32050\d{5}|32115\d{5}|32390\d{5}|32400\d{5}|32420\d{5}|32440\d{5}|32500\d{5}|32630\d{5}|32681\d{5}|32682\d{5}|32685\d{5}|32968\d{5}|33320\d{5}|33870\d{5}|33990\d{5}|34000\d{5}|34029\d{5}|34030\d{5}|34253\d{5}|34310\d{5}|34400\d{5}|34420\d{5}|34880\d{5}|34938\d{5}|35000\d{5}|35899\d{5}|35980\d{5}|35990\d{5})$/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we put one comment what this regex is doing?

And please check in multiple browsers for this regex.

@PritishBudhiraja PritishBudhiraja changed the title feat: pagobancomat card scheme regex addition chore: pagobancomat card scheme regex addition Nov 6, 2024
@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants