Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): remove first_attempt group by in Payment Intent old metrics #6626

Closed
tsdk02 opened this issue Nov 21, 2024 · 0 comments · Fixed by #6627
Closed

fix(analytics): remove first_attempt group by in Payment Intent old metrics #6626

tsdk02 opened this issue Nov 21, 2024 · 0 comments · Fixed by #6627
Assignees
Labels

Comments

@tsdk02
Copy link
Contributor

tsdk02 commented Nov 21, 2024

first_attempt as a group by is getting added internally in the queries as it is required by the new PaymentIntent based metrics for Analytics V2 Dashboard.

The logic was added for the existing older metrics as well for PaymentIntents on the older dashboard, and is failing when using sqlx as the Pool.

Need to remove the logic for adding first_attempt as a group_by in the older metrics, and also tweak the manner in which this is getting added as a group_by in the new metrics.

@tsdk02 tsdk02 added A-Analytics C-bug Category: Bug labels Nov 21, 2024
@tsdk02 tsdk02 self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant