Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add update-flake-lock cron jobs for example-{simple, share-services} and test #168

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

shivaraj-bh
Copy link
Member

resolves #167

@shivaraj-bh
Copy link
Member Author

Ideally it would be preferable to have all these flakes follow the same input, like in haskell-flake, but that will break a couple of just commands that depends on test flake.

@shivaraj-bh shivaraj-bh requested a review from srid April 21, 2024 12:24
@shivaraj-bh shivaraj-bh merged commit 4a48d4a into main Apr 22, 2024
3 checks passed
@shivaraj-bh shivaraj-bh deleted the update-flake-lock branch April 22, 2024 10:29
Copy link
Member

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, let this slip by. But LGTM.

The N CI actions for N examples is not scaleable long-term, so we need DeterminateSystems/update-flake-lock#82

Copy link
Member

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, let this slip by. But LGTM.

The N CI actions for N examples is not scaleable long-term, so we need DeterminateSystems/update-flake-lock#82

@shivaraj-bh
Copy link
Member Author

I tried out hci-effects: shivaraj-bh#4. It works great, supports multi-flake lock update and also auto-merges the PR.

And I can configure it in the dev flake: shivaraj-bh@a9a76ba

@srid
Copy link
Member

srid commented Apr 23, 2024

I tried out hci-effects: shivaraj-bh#4. It works great, supports multi-flake lock update and also auto-merges the PR.

And I can configure it in the dev flake: shivaraj-bh@a9a76ba

Would be nice if we can decouple that from HCI, so as to be able to reuse it in Github Actions. I haven't looked at it in detail though.

But to use HCI (vs self-hosted Github runners) for juspay projects is something that takes a larger consideration (if you remember, we did discuss it internally last year a bit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Update example sub-flakes on regular basis
2 participants