Fix agent cleanup and UI pruning #373
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub async fn cancel_agent(&mut self, agent_id: &str) -> bool { | ||
| if let Some(token) = self.cancel_tokens.remove(agent_id) { | ||
| token.cancel(); | ||
| } | ||
| if let Some(handle) = self.handles.remove(agent_id) { | ||
| handle.abort(); | ||
| if let Some(agent) = self.agents.get_mut(agent_id) { | ||
| agent.status = AgentStatus::Cancelled; | ||
| agent.completed_at = Some(Utc::now()); | ||
| } | ||
| self.prune_finished_agents(); | ||
| true |
There was a problem hiding this comment.
The new cancellation flow creates CancellationTokens and teaches execute_cloud_built_in_streaming to kill the spawned child when the token is tripped, but cancel_agent still calls handle.abort() immediately after cancelling the token. Aborting the task drops the whole future before it can reach the tokio::select! that sends child.start_kill() and awaits the child, so the subprocess keeps running just as before. For a user that stops an agent run, the task is removed from the manager yet the external process continues executing in the background. To actually reap the child, let the task observe the cancellation token (or wait for the task to finish) instead of aborting it right away.
Useful? React with 👍 / 👎.
Summary